1. Forum
  2. DOVE-Net
  3. Synchronet Sysops Only

  • Global JS function parameter validation and updated return types

    From Deucе@VERT to GitLab note in main/sbbs on Saturday, January 18, 2025 06:02:44
    https://gitlab.synchro.net/main/sbbs/-/commit/4914fa1d793e33bd0027b3f82196814c16881bdd#note_6277

    It's not clear what the meaning of this array is compared to a value of 0 in func_list, but it's obvious they do different things.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Saturday, January 18, 2025 11:14:20
    https://gitlab.synchro.net/main/sbbs/-/commit/4914fa1d793e33bd0027b3f82196814c16881bdd#note_6278

    If a function exists in `func_list` with a value of 0, then it is expected to be callable with `null` or `undefined` as the first argument //without// throwing an exception.

    If a function exists in `noargs_required` then it is expected to be callable with **no** arguments without throwing an exception.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to GitLab note in main/sbbs on Saturday, January 18, 2025 18:26:03
    https://gitlab.synchro.net/main/sbbs/-/commit/4914fa1d793e33bd0027b3f82196814c16881bdd#note_6279

    I guess the comment is wrong then?
    `// Value (e.g. 0, 1) is number of non-null/undefined args required`

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Saturday, January 18, 2025 19:50:00
    https://gitlab.synchro.net/main/sbbs/-/commit/4914fa1d793e33bd0027b3f82196814c16881bdd#note_6280

    How is that wrong? If the element value is 0, then a caller can call the function with a (single) null/undefined argument. If it's 1, they can't (it'll throw an exception).

    Calling with a null/undefined argument is different than calling with no arguments.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to GitLab note in main/sbbs on Sunday, January 19, 2025 10:28:23
    https://gitlab.synchro.net/main/sbbs/-/commit/4914fa1d793e33bd0027b3f82196814c16881bdd#note_6281

    It translates to "Zero is the number of non-null/undefined args required." Which does not translate to "One is the number of null/undefined args allowed."

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net